Matthias Clasen [Sat, 29 Feb 2020 17:53:26 +0000 (12:53 -0500)]
broadway: Stop using gdk_surface_raise
We don't implement this anyway. Add a shortcut
to the backend function in case we ever do.
Matthias Clasen [Sat, 29 Feb 2020 17:37:51 +0000 (12:37 -0500)]
x11: Stop abusing type hints for dnd
Nothing in GDK depends on this being set, so just
don't do it.
Matthias Clasen [Sat, 29 Feb 2020 17:25:51 +0000 (12:25 -0500)]
wayland: Stop abusing type hints
Instead of misusing window type hints, introduce
a private flag for drag surfaces.
Matthias Clasen [Wed, 11 Mar 2020 05:15:43 +0000 (01:15 -0400)]
surface: Drop popup api
We have the GdkPopup interface now.
Matthias Clasen [Sat, 29 Feb 2020 14:46:13 +0000 (09:46 -0500)]
tooltip: Use GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:44:05 +0000 (09:44 -0500)]
popover: Use GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:34:11 +0000 (09:34 -0500)]
surface: Implement GdkPopup
This is not quite right, and only temporary, since
it makes GDK_IS_POPUP (surface) true for every surface.
Eventually, the implementation will be moved to the
backends.
Matthias Clasen [Sat, 29 Feb 2020 14:17:02 +0000 (09:17 -0500)]
Introduce GdkPopup
This is a new interface for popup surfaces.
Matthias Clasen [Mon, 9 Mar 2020 20:36:38 +0000 (13:36 -0700)]
popuplayout: Add docs
Matthias Clasen [Sat, 29 Feb 2020 14:17:23 +0000 (09:17 -0500)]
Move GdkSurface autocleanup declaration
We need this available after including gdksurface.h.
Matthias Clasen [Sat, 29 Feb 2020 14:51:26 +0000 (09:51 -0500)]
wayland: Stop calling frontend surface api
This is an unnecessary vfunc roundtrip, and the
frontend api is going away shortly.
Matthias Clasen [Sat, 29 Feb 2020 16:25:32 +0000 (11:25 -0500)]
Simplify surface move/drag api
Drop the with_device variants, and always pass a device.
Matthias Clasen [Wed, 11 Mar 2020 20:37:32 +0000 (16:37 -0400)]
testsuite: Update a11y test output
Matthias Clasen [Wed, 11 Mar 2020 20:37:10 +0000 (16:37 -0400)]
testsuite: Stop using GtkSpinner::active
This property was renamed to ::spinning.
Matthias Clasen [Sat, 29 Feb 2020 16:14:01 +0000 (11:14 -0500)]
Drop gtk_window_begin_move/resize_drag
These are just simple wrappers around GdkSurface
api, and we don't need them.
Matthias Clasen [Wed, 11 Mar 2020 20:41:02 +0000 (16:41 -0400)]
disable popover test
This is failing atm
sicklylife [Mon, 9 Mar 2020 12:49:58 +0000 (12:49 +0000)]
Update Japanese translation
sicklylife [Mon, 9 Mar 2020 12:36:08 +0000 (12:36 +0000)]
Update Japanese translation
Matthias Clasen [Fri, 6 Mar 2020 18:02:06 +0000 (18:02 +0000)]
Merge branch 'master' into 'master'
builder-tool: rename show-close-button to show-title-buttons
See merge request GNOME/gtk!1497
Alexander Larsson [Fri, 6 Mar 2020 10:48:16 +0000 (10:48 +0000)]
Merge branch 'wip/tbaederr/fallthrough' into 'master'
Replace fallthrough comments with G_GNUC_FALLTHROUGH
See merge request GNOME/gtk!1505
Timm Bäder [Fri, 6 Mar 2020 07:32:21 +0000 (08:32 +0100)]
Replace fallthrough comments with G_GNUC_FALLTHROUGH
Benjamin Otte [Fri, 6 Mar 2020 05:48:56 +0000 (05:48 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!1504
Benjamin Otte [Fri, 6 Mar 2020 04:56:29 +0000 (05:56 +0100)]
stack: Make static analyzer happy
Benjamin Otte [Fri, 6 Mar 2020 04:53:20 +0000 (05:53 +0100)]
pathbar: Don't do the same thing twice.
Don't do the same thing twice.
Benjamin Otte [Fri, 6 Mar 2020 04:52:44 +0000 (05:52 +0100)]
reftest: Plug memleak
Benjamin Otte [Fri, 6 Mar 2020 04:51:37 +0000 (05:51 +0100)]
treeview: Don't assign value twice.
Benjamin Otte [Fri, 6 Mar 2020 04:50:35 +0000 (05:50 +0100)]
cellarea: Be very clear
The static analyzer needs to know we absolutely DO NOT want to use this
return value.
Benjamin Otte [Fri, 6 Mar 2020 04:29:46 +0000 (05:29 +0100)]
builder-tool: Don't allow property to be both resize and shrink
Otherwise builder-tool crashes when you do
<property name="shrink" name="resize">1</property>
Thanks to the static analyzer for figuring that one out.
Benjamin Otte [Fri, 6 Mar 2020 04:06:25 +0000 (05:06 +0100)]
applicationaccels: Use g_renew()
Benjamin Otte [Fri, 6 Mar 2020 04:03:45 +0000 (05:03 +0100)]
liststore: Fix gtk_list_store_iter_is_valid()
The iter may be invalid, so we may not read from it.
testsuite/gtk/treemodel tests this and valgrind is shouting about it,
but it never crashed until I just ran it...
This bug is from 2004 and the test is from 2007. I guess invalid memory
accesses don't get caught by CI much.
Benjamin Otte [Fri, 6 Mar 2020 04:01:01 +0000 (05:01 +0100)]
testtreeview: Fix 19 year old use-after-free
Benjamin Otte [Fri, 6 Mar 2020 03:31:30 +0000 (04:31 +0100)]
treepath: Use g_renew()
Benjamin Otte [Fri, 6 Mar 2020 03:31:08 +0000 (04:31 +0100)]
testsuite: Avoid passing NULL to strcmp()
Use g_strcmp0() instead.
Benjamin Otte [Fri, 6 Mar 2020 03:24:30 +0000 (04:24 +0100)]
treeview: Don't initialize variable twice
Benjamin Otte [Thu, 5 Mar 2020 18:20:36 +0000 (18:20 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!1502
Benjamin Otte [Thu, 5 Mar 2020 06:02:24 +0000 (07:02 +0100)]
build: Add -Wnull-dereference
Sprinkle various g_assert() around the code where gcc cannot figure out
on its own that a variable is not NULL and too much refactoring would be
needed to make it do that.
Also fix usage of g_assert_nonnull(x) to use g_assert(x) because the
first is not marked as G_GNUC_NORETURN because of course GTester
supports not aborting on aborts.
Benjamin Otte [Thu, 5 Mar 2020 06:56:01 +0000 (07:56 +0100)]
icontheme: Remove unused parameter
It's only ever set to NULL (and then dereferenced, too)
Benjamin Otte [Thu, 5 Mar 2020 05:58:44 +0000 (06:58 +0100)]
treerbtree: Use for loops
Makes the code more readable.
Also does the NULL check for the initial element, which was misisng
before.
Benjamin Otte [Thu, 5 Mar 2020 05:58:12 +0000 (06:58 +0100)]
notebook: Don't crash on drags not coming from a notebook
Benjamin Otte [Thu, 5 Mar 2020 05:57:44 +0000 (06:57 +0100)]
icontheme: Don't crash on icon lookup failure
Benjamin Otte [Thu, 5 Mar 2020 05:57:26 +0000 (06:57 +0100)]
device: Handle missing axis
Benjamin Otte [Thu, 5 Mar 2020 05:53:26 +0000 (06:53 +0100)]
rbtree: Simplify macros
* NODE_FROM_POINTER() can not be NULL
* shuffle NODE_TO_POINTER() code for readability so that the NULL check
is on the outside and not the cast
Benjamin Otte [Thu, 5 Mar 2020 05:51:32 +0000 (06:51 +0100)]
rbtree: Simplify code
This makes it easier to understand for gcc (and hopefully humans, too)
that by rotating we essentially just swap `node` and `p`.
Benjamin Otte [Thu, 5 Mar 2020 02:58:29 +0000 (03:58 +0100)]
build: Add more useful warning flags
I found those on the interwebs and decided they are useful.
Benjamin Otte [Thu, 5 Mar 2020 05:14:58 +0000 (06:14 +0100)]
mountoperation-x11: Fix copy/paste thinko
Benjamin Otte [Wed, 4 Mar 2020 00:24:32 +0000 (01:24 +0100)]
tests: Add a test for changing the hovered widget
The add/remove one crashes after a few enter/leave events.
Benjamin Otte [Thu, 5 Mar 2020 02:57:53 +0000 (03:57 +0100)]
imcontextwayland: Fix copy/paste error
Benjamin Otte [Thu, 5 Mar 2020 02:57:24 +0000 (03:57 +0100)]
textview: Fix copy/paste error
Timm Bäder [Wed, 4 Mar 2020 11:01:30 +0000 (11:01 +0000)]
Merge branch 'patch-1' into 'master'
gdk_monitor_get_model: Fix a typo in the function documentation
See merge request GNOME/gtk!1499
Antenore Gatta [Tue, 3 Mar 2020 09:51:48 +0000 (09:51 +0000)]
gdk_monitor_get_model: Fix a typo in the function documentation
Piotr Drąg [Tue, 3 Mar 2020 16:10:36 +0000 (17:10 +0100)]
Update POTFILES.in
Emmanuele Bassi [Tue, 3 Mar 2020 15:30:43 +0000 (15:30 +0000)]
Merge branch 'doc-fixes' into 'master'
Small documentation fixes
See merge request GNOME/gtk!1500
Emmanuele Bassi [Tue, 3 Mar 2020 13:17:31 +0000 (13:17 +0000)]
Fix annotation for GtkDropTarget.get_gtypes()
The argument name must match in the documentation, and the `allow-none`
annotation is deprecated, and should be replaced by `optional` in this
case.
Emmanuele Bassi [Tue, 3 Mar 2020 13:13:26 +0000 (13:13 +0000)]
Remove incorrect rename-to annotations
The `rename-to` annotation is used to "shadow" a symbol with another
one, which means both symbols need to exist. It can't be used to rename
a symbol to something else.
Emmanuele Bassi [Tue, 3 Mar 2020 13:12:52 +0000 (13:12 +0000)]
Fix introspection warnings for GtkDragIcon
Emmanuele Bassi [Mon, 2 Mar 2020 12:42:43 +0000 (12:42 +0000)]
Add missing annotation for GtkIconTheme
sicklylife [Tue, 3 Mar 2020 12:09:06 +0000 (12:09 +0000)]
Update Japanese translation
sicklylife [Tue, 3 Mar 2020 12:06:32 +0000 (12:06 +0000)]
Update Japanese translation
Matthias Clasen [Tue, 3 Mar 2020 08:40:43 +0000 (08:40 +0000)]
Merge branch 'gbsneto/gtkeventcontrollerfocus' into 'master'
build: Install gtkeventcontrollerfocus.h
See merge request GNOME/gtk!1498
Georges Basile Stavracas Neto [Tue, 3 Mar 2020 03:38:13 +0000 (00:38 -0300)]
build: Install gtkeventcontrollerfocus.h
It's a public class, and is included by gtk.h. Ship it.
Matt Guerrette [Tue, 3 Mar 2020 03:24:46 +0000 (22:24 -0500)]
builder-tool: rename show-close-button to show-title-buttons
For GtkHeaderBar show-close-button has been renamed to
show-title-buttons for GTK4. This commit adds this fixup to the builder
tool
Benjamin Otte [Mon, 2 Mar 2020 21:32:20 +0000 (21:32 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!1496
Benjamin Otte [Mon, 2 Mar 2020 20:45:59 +0000 (21:45 +0100)]
droptarget: Fast-path local value load
This way, we can ensure that for local same-type drops the GValue
is set when ::enter is emitted.
This is the common case for dnd between widgets inside larger
applications, so it's worth it to speed it up.
Benjamin Otte [Mon, 2 Mar 2020 20:45:42 +0000 (21:45 +0100)]
drop: Don't use g_object_get()
Benjamin Otte [Mon, 2 Mar 2020 20:26:08 +0000 (21:26 +0100)]
dnd: Fix some documentation gotchas
Benjamin Otte [Mon, 2 Mar 2020 18:09:05 +0000 (18:09 +0000)]
Merge branch 'wip/otte/dnd' into 'master'
DND: Sync drop target
See merge request GNOME/gtk!1495
Benjamin Otte [Mon, 2 Mar 2020 03:15:39 +0000 (04:15 +0100)]
drop: Remove unused convenience APIs
With the new event controllers, these are unused.
Benjamin Otte [Mon, 2 Mar 2020 03:10:31 +0000 (04:10 +0100)]
themes: Set proper foreground color for DND icons
Benjamin Otte [Mon, 2 Mar 2020 03:03:03 +0000 (04:03 +0100)]
calendar: Use a drag source
Benjamin Otte [Mon, 2 Mar 2020 02:46:59 +0000 (03:46 +0100)]
dnd: Don't create custom color drag icons
... use the default one. It looks much better.
Benjamin Otte [Mon, 2 Mar 2020 02:11:14 +0000 (03:11 +0100)]
dragicon: Add gtk_drag_icon_create_widget_for_value()
... and use it to set a drag icon.
Benjamin Otte [Mon, 2 Mar 2020 02:39:14 +0000 (03:39 +0100)]
contentformats: Constify some functions
Benjamin Otte [Mon, 2 Mar 2020 01:55:38 +0000 (02:55 +0100)]
dragicon: Change how to acquire drag icons
Before, gtk_drag_icon_new_for_drag() allowed creating new drag icons.
This could cause multiple drag icons to exist for a single drag.
Now, gtk_drag_icon_get_for_drag() makes sure that only one drag icon is
created.
Benjamin Otte [Sun, 1 Mar 2020 21:28:39 +0000 (22:28 +0100)]
dragicon: Add GtkDragIcon::child
Benjamin Otte [Sun, 1 Mar 2020 17:50:15 +0000 (18:50 +0100)]
gdk: Make gdk_drop_status() take preferred action
This allows textview/text dnd to properly display a MOVE icon when in
the widget the drag started from but a COPY icon otherwise.
Benjamin Otte [Sun, 1 Mar 2020 16:32:40 +0000 (17:32 +0100)]
colorswatch: Switch to dragged color during dnd
This is really simple to implement now, so do it.
Benjamin Otte [Sun, 1 Mar 2020 07:45:15 +0000 (08:45 +0100)]
gtk-demo: Add a simple peg solitaire DND demo
Benjamin Otte [Sat, 29 Feb 2020 02:47:17 +0000 (03:47 +0100)]
droptarget: Redo
This is a huge reorganization of GtkDropTarget. I did not know how to
split this up, so it's unfortunately all one commit.
Highlights:
- Split GtkDropTarget into GtkDropTarget and GtkDropTargetAsync
GtkDropTarget is the simple one that only works with GTypes and offers
a synchronous interface.
GtkDropTargetAsync retains the full old functionality and allows
handling mime types.
- Drop events are handled differently
Instead of picking a single drop target and sending all DND events to
it, every event is sent to every drop target. The first one to handle
the event gets to call gdk_drop_status(), further handlers do not
interact with the GdkDrop.
Of course, for the ultimate GDK_DROP_STARTING event, only the first
one to accept the drop gets to handle it.
This allows stacking DND event controllers that aren't necessarily
interested in handling the event or that might decide later to drop
it.
- Port all widgets to either of those
Both have a somewhat changed API due to the new event handling.
For the ones who should use the sync version, lots of cleanup was
involved to operate on a sync API.
Benjamin Otte [Sun, 1 Mar 2020 01:56:09 +0000 (02:56 +0100)]
placessidebar: Don't use the GdkDrag
First, it should have been a GdkDrop, but even then, proper DND code
should not rely on internals.
It's only been used in an unused signal emission anyway.
Benjamin Otte [Sat, 29 Feb 2020 05:29:27 +0000 (06:29 +0100)]
notebook: Make dnd page switching a drop controller
This untangles tab dnd from page switching.
Benjamin Otte [Sat, 29 Feb 2020 03:37:16 +0000 (04:37 +0100)]
textview: Move drop scrolling to drop motion controller
Don't confuse the drop target with it.
Benjamin Otte [Fri, 28 Feb 2020 03:19:36 +0000 (04:19 +0100)]
treeview, iconview: Don't return the drop target
Not a good idea to hand internal event controllers out to public API.
Benjamin Otte [Tue, 25 Feb 2020 21:42:10 +0000 (22:42 +0100)]
testsuite: Use g_assert() in tests
Emmanuele Bassi [Sun, 1 Mar 2020 15:07:17 +0000 (15:07 +0000)]
Merge branch 'piotrdrag/placessidebar-typos' into 'master'
placessidebar: Fix a couple of typos and thinkos in menu labels
See merge request GNOME/gtk!1494
Piotr Drąg [Sun, 1 Mar 2020 14:05:28 +0000 (15:05 +0100)]
placessidebar: Fix a couple of typos and thinkos in menu labels
Matthias Clasen [Sat, 29 Feb 2020 01:19:48 +0000 (01:19 +0000)]
Merge branch 'kill-grabs-2' into 'master'
Kill grabs
See merge request GNOME/gtk!1492
Matthias Clasen [Fri, 28 Feb 2020 21:36:17 +0000 (16:36 -0500)]
Drop gtk_grab_add/remove from public api
The only form in which we still allow grabs to take place
is with modal toplevels.
Matthias Clasen [Fri, 28 Feb 2020 21:29:56 +0000 (16:29 -0500)]
Drop gtk_grab_get_current
Another grab-related api that we are not using.
Matthias Clasen [Fri, 28 Feb 2020 21:27:42 +0000 (16:27 -0500)]
Drop device grabs
We were not using this api at all, so lets drop it.
Matthias Clasen [Fri, 28 Feb 2020 20:35:11 +0000 (20:35 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
inspector: Fix the "Software GL" switch
See merge request GNOME/gtk!1491
Matthias Clasen [Fri, 28 Feb 2020 19:42:19 +0000 (14:42 -0500)]
inspector: Fix the "Software GL" switch
This was crashing.
Piotr Drąg [Thu, 27 Feb 2020 21:05:24 +0000 (22:05 +0100)]
Update POTFILES.in and POTFILES.skip
Matthias Clasen [Thu, 27 Feb 2020 20:29:04 +0000 (20:29 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1488
Matthias Clasen [Thu, 27 Feb 2020 19:07:12 +0000 (14:07 -0500)]
Remove a stray g_object_unref
Events are no longer objects, so this does not do
any good. Use gdk_event_unref instead.
Matthias Clasen [Thu, 27 Feb 2020 12:47:37 +0000 (07:47 -0500)]
Avoid a crash in css font features values
Nathan Follens [Thu, 27 Feb 2020 11:05:23 +0000 (11:05 +0000)]
Update Dutch translation
Timm Bäder [Thu, 27 Feb 2020 10:41:44 +0000 (10:41 +0000)]
Merge branch 'patch-1' into 'master'
Fix a typo in gtkplacessidebar.c
See merge request GNOME/gtk!1486
Krzesimir Nowak [Thu, 27 Feb 2020 10:02:56 +0000 (10:02 +0000)]
Fix a typo in gtkplacessidebar.c
Some mistyped vim command got into the code in commit
60d2813247831adf9642f87ad2bf597280d2f31a.
Matthias Clasen [Thu, 27 Feb 2020 01:12:23 +0000 (01:12 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Fix a leftover occurrence of ::expand
See merge request GNOME/gtk!1485
Matthias Clasen [Thu, 27 Feb 2020 00:31:25 +0000 (19:31 -0500)]
Fix a leftover occurrence of ::expand